Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: not report when no gpu device #636

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Sep 19, 2022

Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com

Ⅰ. Describe what this PR does

fix #618

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 68.96% // Head: 68.98% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (d181c1b) compared to base (eb9762e).
Patch coverage: 52.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   68.96%   68.98%   +0.02%     
==========================================
  Files         196      196              
  Lines       22308    22321      +13     
==========================================
+ Hits        15384    15398      +14     
- Misses       5856     5857       +1     
+ Partials     1068     1066       -2     
Flag Coverage Δ
unittests 68.98% <52.38%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_device_linux.go 42.40% <0.00%> (-0.68%) ⬇️
pkg/util/resource.go 45.45% <0.00%> (-4.55%) ⬇️
pkg/slo-controller/noderesource/noderesource.go 74.21% <73.33%> (-1.75%) ⬇️
pkg/util/httputil/reverseproxy.go 85.37% <0.00%> (+1.06%) ⬆️
pkg/scheduler/plugins/elasticquota/controller.go 78.57% <0.00%> (+9.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/slo-controller/noderesource/noderesource.go Outdated Show resolved Hide resolved
pkg/util/resource.go Outdated Show resolved Hide resolved
@zwzhang0107
Copy link
Contributor

/lgtm

Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
others PTAL

@koordinator-bot koordinator-bot bot added the lgtm label Sep 21, 2022
@hormes
Copy link
Member

hormes commented Sep 21, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1167704 into koordinator-sh:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Node.Status should not display device resource when there is no corresponding device
4 participants