koord-scheduler: add device scheduling debug api #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buptcozy
force-pushed
the
device-share-debug-api
branch
from
bb3bf36
to
13e6824
Compare
Codecov ReportBase: 68.90% // Head: 68.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
+ Coverage 68.90% 68.97% +0.06%
==========================================
Files 194 196 +2
Lines 22180 22304 +124
==========================================
+ Hits 15284 15384 +100
- Misses 5832 5856 +24
Partials 1064 1064
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
buptcozy
changed the title
eahydra
reviewed
Sep 19, 2022
buptcozy
force-pushed
the
device-share-debug-api
branch
from
13e6824
to
642575b
Compare
buptcozy
changed the title
buptcozy
force-pushed
the
device-share-debug-api
branch
from
642575b
to
46819f8
Compare
buptcozy
changed the title
buptcozy
changed the title
buptcozy
changed the title
eahydra
reviewed
Sep 19, 2022
| @@ -89,7 +88,15 @@ func (n *nodeDeviceCache) update(nodeName string, device *schedulingv1alpha1.Dev | |||
| if nodeDeviceResource[deviceInfo.Type] == nil { | |||
| nodeDeviceResource[deviceInfo.Type] = make(deviceResources) | |||
| } | |||
| nodeDeviceResource[deviceInfo.Type][int(deviceInfo.Minor)] = deviceInfo.Resources | |||
| if !deviceInfo.Health { | |||
buptcozy
force-pushed
the
device-share-debug-api
branch
2 times, most recently
from
0117d69
to
1b83aeb
Compare
eahydra
changed the title
eahydra
reviewed
Sep 19, 2022
buptcozy
force-pushed
the
device-share-debug-api
branch
2 times, most recently
from
9840c53
to
efaeb0f
Compare
- add device share debug api - support assign fail if card unhealthy Signed-off-by: yangzhang <bupt_cozy@126.com>
buptcozy
force-pushed
the
device-share-debug-api
branch
from
efaeb0f
to
ed33ebe
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yangzhang bupt_cozy@126.com
Ⅰ. Describe what this PR does
add restful api for device scheduling plugin to help diagnose problems
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test