-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just tidy up some logic #644
Conversation
Signed-off-by: lucming <2876757716@qq.com>
Codecov ReportBase: 68.81% // Head: 68.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 68.81% 68.81%
=======================================
Files 196 196
Lines 22322 22329 +7
=======================================
+ Hits 15360 15365 +5
Misses 5886 5886
- Partials 1076 1078 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cool, are you trying to use koordinator in internal environment? looking forward to hearing your voice: #466 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks for your contribution.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yes,we intend to something about mixed deploy,this project will be used as a shelf. |
Signed-off-by: lucming 2876757716@qq.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test