Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix memory evict for nil podMetric #648

Merged

Conversation

saintube
Copy link
Member

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

fix the panic in memory evict candidate sorting when any pod metric is not found

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 68.84% // Head: 68.77% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (ec0fae2) compared to base (ba978b4).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   68.84%   68.77%   -0.08%     
==========================================
  Files         196      196              
  Lines       22335    22329       -6     
==========================================
- Hits        15377    15357      -20     
- Misses       5880     5891      +11     
- Partials     1078     1081       +3     
Flag Coverage Δ
unittests 68.77% <62.50%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/memory_evict.go 69.82% <62.50%> (-2.25%) ⬇️
pkg/scheduler/plugins/elasticquota/controller.go 68.05% <0.00%> (-10.52%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (-1.33%) ⬇️
...kg/scheduler/plugins/elasticquota/plugin_helper.go 79.78% <0.00%> (ø)
pkg/scheduler/plugins/elasticquota/plugin.go 74.00% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Sep 21, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c955b2e into koordinator-sh:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants