-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use pointer for minor in device crd #656
fix: use pointer for minor in device crd #656
Conversation
405d39e
to
3915961
Compare
@buptcozy please review this pr |
/hold |
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
3915961
to
e9e4fa7
Compare
/hold cancel |
Codecov ReportBase: 68.87% // Head: 68.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
- Coverage 68.87% 68.83% -0.04%
==========================================
Files 203 203
Lines 22906 22929 +23
==========================================
+ Hits 15776 15784 +8
- Misses 6031 6044 +13
- Partials 1099 1101 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 3163e70. Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Signed-off-by: Jason Liu jasonliu747@gmail.com
Ⅰ. Describe what this PR does
Use a pointer for the minor field, so that the zero value of the JSON type can be differentiated from the missing value.
Ⅱ. Does this pull request fix one issue?
fixes #655
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test