Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pointer for minor in device crd #656

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Use a pointer for the minor field, so that the zero value of the JSON type can be differentiated from the missing value.

Ⅱ. Does this pull request fix one issue?

fixes #655

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@hormes
Copy link
Member

hormes commented Sep 23, 2022

@buptcozy please review this pr

@jasonliu747
Copy link
Member Author

/hold
CI keeps failing, havn't figured it out yet.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@jasonliu747
Copy link
Member Author

/hold cancel

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 68.87% // Head: 68.83% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e9e4fa7) compared to base (8642578).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   68.87%   68.83%   -0.04%     
==========================================
  Files         203      203              
  Lines       22906    22929      +23     
==========================================
+ Hits        15776    15784       +8     
- Misses       6031     6044      +13     
- Partials     1099     1101       +2     
Flag Coverage Δ
unittests 68.83% <87.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/scheduler/plugins/deviceshare/device_handler.go 92.06% <50.00%> (ø)
pkg/koordlet/reporter/reporter.go 54.40% <100.00%> (ø)
pkg/koordlet/statesinformer/states_device_linux.go 42.70% <100.00%> (+0.29%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/scheduler/plugins/elasticquota/controller.go 65.33% <0.00%> (-2.73%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️
...eduler/plugins/coscheduling/controller/podgroup.go 72.27% <0.00%> (-0.14%) ⬇️
...slo-controller/noderesource/resource_calculator.go 100.00% <0.00%> (ø)
pkg/slo-controller/config/config.go 92.30% <0.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 3163e70 into koordinator-sh:main Sep 30, 2022
jasonliu747 added a commit that referenced this pull request Oct 8, 2022
This reverts commit 3163e70.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@jasonliu747 jasonliu747 deleted the update-device-crd branch October 20, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] minor in device crd is empty when it should be 0
4 participants