Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct pod informer delete event #669

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #668

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 68.91% // Head: 68.85% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (c66c102) compared to base (1e1895b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   68.91%   68.85%   -0.07%     
==========================================
  Files         203      203              
  Lines       22928    22928              
==========================================
- Hits        15800    15786      -14     
- Misses       6033     6040       +7     
- Partials     1095     1102       +7     
Flag Coverage Δ
unittests 68.85% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/plugin.go 90.05% <100.00%> (ø)
pkg/scheduler/plugins/elasticquota/controller.go 65.33% <0.00%> (-10.67%) ⬇️
...eduler/plugins/coscheduling/controller/podgroup.go 70.29% <0.00%> (-1.99%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit dc77ce7 into koordinator-sh:main Sep 30, 2022
@jasonliu747 jasonliu747 deleted the fix-gpu branch October 20, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Pod 被删除之后 GPU 账本中仍然存在该记录
1 participant