Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix cpuset hook for unset cfs #680

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented Oct 9, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

bugfix for the registration of the cpuset runtime hook

Ⅱ. Does this pull request fix one issue?

fixes #677

Ⅲ. Describe how to verify it

  1. do not fail on unit tests
  2. run koordlet successfully without panic

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 68.77% // Head: 68.81% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (09b47ff) compared to base (3c2cee8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   68.77%   68.81%   +0.03%     
==========================================
  Files         204      204              
  Lines       22959    22962       +3     
==========================================
+ Hits        15791    15801      +10     
+ Misses       6072     6061      -11     
- Partials     1096     1100       +4     
Flag Coverage Δ
unittests 68.81% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/hooks/cpuset/cpuset.go 90.47% <100.00%> (+20.10%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the fix-cpuset-hook-for-unset-cfs branch from 3516b45 to 09b47ff Compare October 9, 2022 05:15
@hormes
Copy link
Member

hormes commented Oct 9, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f89f000 into koordinator-sh:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] koordlet panic when startup
2 participants