Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: optimize the use of GroupQuotaManager's hierarchyLock #681

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

xulinfei1996
Copy link
Contributor

@xulinfei1996 xulinfei1996 commented Oct 9, 2022

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Make groupQuotaManager's hierarchyUpdateLock not exposed, then modify the functions call groupQuotaManager's corresponding functions.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 68.92% // Head: 68.66% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (0b53d0c) compared to base (22e9d78).
Patch coverage: 36.52% of modified lines in pull request are covered.

❗ Current head 0b53d0c differs from pull request most recent head da6e095. Consider uploading reports for the commit da6e095 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   68.92%   68.66%   -0.26%     
==========================================
  Files         205      205              
  Lines       23329    23341      +12     
==========================================
- Hits        16079    16028      -51     
- Misses       6141     6208      +67     
+ Partials     1109     1105       -4     
Flag Coverage Δ
unittests 68.66% <36.52%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/plugins/elasticquota/core/group_quota_manager.go 71.12% <22.34%> (-10.85%) ⬇️
pkg/scheduler/plugins/elasticquota/controller.go 72.30% <100.00%> (-3.70%) ⬇️
.../scheduler/plugins/elasticquota/core/quota_info.go 82.27% <100.00%> (-2.90%) ⬇️
pkg/scheduler/plugins/elasticquota/node_handler.go 67.69% <100.00%> (+0.50%) ⬆️
pkg/scheduler/plugins/elasticquota/plugin.go 73.64% <100.00%> (-0.36%) ⬇️
...g/scheduler/plugins/elasticquota/plugin_service.go 69.23% <100.00%> (ø)
pkg/scheduler/plugins/elasticquota/pod_handler.go 64.28% <100.00%> (-7.72%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xulinfei1996 xulinfei1996 force-pushed the main-test-tmp branch 2 times, most recently from 282957e to eb5e469 Compare October 9, 2022 09:57
@xulinfei1996 xulinfei1996 force-pushed the main-test-tmp branch 3 times, most recently from 6fbdc8d to ebcf72d Compare October 12, 2022 09:06
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: optimize ElasticQuota and DeviceShare some logics koord-scheduler: optimize ElasticQuota some logics Oct 13, 2022
@xulinfei1996 xulinfei1996 force-pushed the main-test-tmp branch 2 times, most recently from 60234cc to 5399f23 Compare October 13, 2022 02:25
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: optimize ElasticQuota some logics koord-scheduler: reorganize the elasticQuota pod's eventHandlers to be a complete transaction Oct 14, 2022
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: reorganize the elasticQuota pod's eventHandlers to be a complete transaction koord-scheduler: let the groupQuotaManager's hierarchyUpdateLock not exposed. Oct 14, 2022
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: let the groupQuotaManager's hierarchyUpdateLock not exposed. koord-scheduler: make groupQuotaManager's hierarchyUpdateLock not exposed. Oct 14, 2022
@xulinfei1996 xulinfei1996 force-pushed the main-test-tmp branch 4 times, most recently from 04e264c to f8813df Compare October 20, 2022 02:33
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: make groupQuotaManager's hierarchyUpdateLock not exposed. koord-scheduler: reorganize the pod eventHandlers to be a complete transactions Oct 20, 2022
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: reorganize the pod eventHandlers to be a complete transactions koord-scheduler: make groupQuotaManager's hierarchyUpdateLock not exposed. Oct 20, 2022
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: make groupQuotaManager's hierarchyUpdateLock not exposed. koord-scheduler: reorganize the pod eventHandlers to be complete transactions Oct 20, 2022
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: reorganize the pod eventHandlers to be complete transactions koord-scheduler: optimize the use of groupQuotaManager's hierarchyLock Oct 20, 2022
@xulinfei1996 xulinfei1996 changed the title koord-scheduler: optimize the use of groupQuotaManager's hierarchyLock koord-scheduler: optimize the use of GroupQuotaManager's hierarchyLock Oct 20, 2022
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Oct 21, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants