-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: append origin env when inject gpu env #689
Conversation
Codecov ReportBase: 68.85% // Head: 68.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
- Coverage 68.85% 68.64% -0.21%
==========================================
Files 204 205 +1
Lines 22983 23346 +363
==========================================
+ Hits 15824 16027 +203
- Misses 6058 6210 +152
- Partials 1101 1109 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -68,6 +68,7 @@ func (s *server) PreCreateContainerHook(ctx context.Context, | |||
ContainerAnnotations: req.GetContainerAnnotations(), | |||
ContainerResources: req.GetContainerResources(), | |||
PodCgroupParent: req.GetPodCgroupParent(), | |||
ContainerEnvs: req.GetContainerEnvs(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other hooks also should be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只有create能mutate env args,其他阶段没有机会
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
统一对齐吧,就像stop阶段也改不了PodCgroupParent一样
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test