Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: append origin env when inject gpu env #689

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Oct 12, 2022

Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 68.85% // Head: 68.64% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (09684c4) compared to base (2537ed9).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   68.85%   68.64%   -0.21%     
==========================================
  Files         204      205       +1     
  Lines       22983    23346     +363     
==========================================
+ Hits        15824    16027     +203     
- Misses       6058     6210     +152     
- Partials     1101     1109       +8     
Flag Coverage Δ
unittests 68.64% <66.66%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oordlet/runtimehooks/protocol/container_context.go 7.69% <55.55%> (-2.31%) ⬇️
pkg/koordlet/runtimehooks/hooks/gpu/gpu.go 65.62% <100.00%> (ø)
pkg/util/system/system_file.go 85.00% <0.00%> (-15.00%) ⬇️
...r/plugins/elasticquota/core/group_quota_manager.go 71.12% <0.00%> (-13.22%) ⬇️
pkg/scheduler/plugins/elasticquota/pod_handler.go 64.28% <0.00%> (-7.72%) ⬇️
pkg/scheduler/plugins/deviceshare/pod_handler.go 94.59% <0.00%> (-5.41%) ⬇️
...dlet/statesinformer/states_noderesourcetopology.go 60.61% <0.00%> (-4.50%) ⬇️
.../scheduler/plugins/coscheduling/core/gang_cache.go 74.85% <0.00%> (-4.14%) ⬇️
.../scheduler/plugins/elasticquota/core/quota_info.go 82.27% <0.00%> (-2.90%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -68,6 +68,7 @@ func (s *server) PreCreateContainerHook(ctx context.Context,
ContainerAnnotations: req.GetContainerAnnotations(),
ContainerResources: req.GetContainerResources(),
PodCgroupParent: req.GetPodCgroupParent(),
ContainerEnvs: req.GetContainerEnvs(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other hooks also should be added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有create能mutate env args,其他阶段没有机会

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一对齐吧,就像stop阶段也改不了PodCgroupParent一样

Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Oct 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e197449 into koordinator-sh:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants