Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: abstract nodenumaresource plugin allowUseCPUSet #690

Conversation

ZiMengSheng
Copy link
Contributor

Signed-off-by: wangjianyu zmsjianyu@gmail.com

Ⅰ. Describe what this PR does

this PR abstracts nodenumaresource plugin checklogic of QoS and priority.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 68.85% // Head: 68.95% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (e0984d4) compared to base (2537ed9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   68.85%   68.95%   +0.10%     
==========================================
  Files         204      204              
  Lines       22983    23079      +96     
==========================================
+ Hits        15824    15914      +90     
- Misses       6058     6062       +4     
- Partials     1101     1103       +2     
Flag Coverage Δ
unittests 68.95% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/nodenumaresource/plugin.go 64.19% <100.00%> (+0.47%) ⬆️
pkg/util/system/system_file.go 85.00% <0.00%> (-15.00%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️
...et/runtimehooks/hooks/groupidentity/interceptor.go 100.00% <0.00%> (ø)
.../koordlet/runtimehooks/hooks/groupidentity/rule.go 85.47% <0.00%> (+1.50%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️
...g/koordlet/runtimehooks/hooks/groupidentity/bvt.go 90.38% <0.00%> (+11.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZiMengSheng ZiMengSheng force-pushed the nodenumaresource-allowByQoSAndPriority branch from d4a6e52 to b1f9209 Compare October 12, 2022 10:02
@koordinator-bot koordinator-bot bot added size/XS and removed size/S labels Oct 12, 2022
@ZiMengSheng ZiMengSheng changed the title koord-scheduler: abstract nodenumaresource plugin checklogic of QoS and priority koord-scheduler: abstract nodenumaresource plugin allowCPUSet Oct 12, 2022
@ZiMengSheng ZiMengSheng force-pushed the nodenumaresource-allowByQoSAndPriority branch from b1f9209 to ce523ce Compare October 12, 2022 10:03
Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
@ZiMengSheng ZiMengSheng force-pushed the nodenumaresource-allowByQoSAndPriority branch from ce523ce to e0984d4 Compare October 12, 2022 10:10
@ZiMengSheng ZiMengSheng changed the title koord-scheduler: abstract nodenumaresource plugin allowCPUSet koord-scheduler: abstract nodenumaresource plugin allowUseCPUSet Oct 12, 2022
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1353433 into koordinator-sh:main Oct 12, 2022
@ZiMengSheng ZiMengSheng deleted the nodenumaresource-allowByQoSAndPriority branch October 12, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants