Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: refactor scheduling config layout for release apis #699

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Oct 14, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

The package apis/scheduling/config depends on k8s.io/kubernetes , and this dependency can cause unnecessary problems when distributing the apis package separately.

Ⅱ. Does this pull request fix one issue?

fix #692

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra added this to the v1.0 milestone Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 68.78% // Head: 68.87% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (08ce593) compared to base (7e76258).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   68.78%   68.87%   +0.09%     
==========================================
  Files         204      205       +1     
  Lines       23143    23317     +174     
==========================================
+ Hits        15918    16060     +142     
- Misses       6121     6148      +27     
- Partials     1104     1109       +5     
Flag Coverage Δ
unittests 68.87% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/coscheduling/core/core.go 39.31% <ø> (ø)
pkg/scheduler/plugins/coscheduling/core/gang.go 76.34% <ø> (ø)
.../scheduler/plugins/coscheduling/core/gang_cache.go 74.69% <ø> (ø)
pkg/scheduler/plugins/coscheduling/coscheduling.go 71.92% <ø> (ø)
pkg/scheduler/plugins/elasticquota/plugin.go 74.00% <ø> (ø)
pkg/scheduler/plugins/loadaware/load_aware.go 75.12% <ø> (ø)
...eduler/plugins/nodenumaresource/cpu_accumulator.go 80.56% <ø> (ø)
...heduler/plugins/nodenumaresource/cpu_allocation.go 95.74% <ø> (ø)
.../scheduler/plugins/nodenumaresource/cpu_manager.go 73.52% <ø> (ø)
...scheduler/plugins/nodenumaresource/cpu_topology.go 53.79% <ø> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Oct 14, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 49c3a4e into koordinator-sh:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] remove the k8s.io/kubernetes dependency in apis/scheduling package
2 participants