Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: fix nodeNUMAResource allowUseCPUSet #710

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Oct 18, 2022

Signed-off-by: wangjianyu zmsjianyu@gmail.com

Ⅰ. Describe what this PR does

this PR fix NodeNUMAResource plugin allowUseCPUSet and make it more general.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
@ZiMengSheng ZiMengSheng force-pushed the nodenumaresource-allowByQoSAndPriority branch from e9cd4b4 to 1493df1 Compare October 18, 2022 08:13
@koordinator-bot koordinator-bot bot added size/S and removed size/XS labels Oct 18, 2022
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 68.87% // Head: 68.83% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (1493df1) compared to base (75441b0).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   68.87%   68.83%   -0.04%     
==========================================
  Files         205      205              
  Lines       23319    23320       +1     
==========================================
- Hits        16060    16052       -8     
- Misses       6150     6157       +7     
- Partials     1109     1111       +2     
Flag Coverage Δ
unittests 68.83% <57.14%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/nodenumaresource/plugin.go 63.04% <57.14%> (-1.15%) ⬇️
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Oct 18, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7fdf007 into koordinator-sh:main Oct 18, 2022
@ZiMengSheng ZiMengSheng deleted the nodenumaresource-allowByQoSAndPriority branch January 13, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants