Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webhook and node topo feature gates control #715

Merged
merged 1 commit into from
Oct 19, 2022
Merged

add webhook and node topo feature gates control #715

merged 1 commit into from
Oct 19, 2022

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Oct 19, 2022

Signed-off-by: 佑祎 zzw261520@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 68.90% // Head: 68.86% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0fe9a56) compared to base (8a6edf2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   68.90%   68.86%   -0.04%     
==========================================
  Files         205      205              
  Lines       23320    23328       +8     
==========================================
- Hits        16068    16065       -3     
- Misses       6145     6155      +10     
- Partials     1107     1108       +1     
Flag Coverage Δ
unittests 68.86% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dlet/statesinformer/states_noderesourcetopology.go 60.61% <0.00%> (-0.85%) ⬇️
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/koordlet/pleg/pleg.go 66.89% <0.00%> (-1.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Oct 19, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0044fda into koordinator-sh:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants