Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete unused return args #724

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

lucming
Copy link
Contributor

@lucming lucming commented Oct 20, 2022

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 68.92% // Head: 68.67% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (ac6452e) compared to base (22e9d78).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   68.92%   68.67%   -0.25%     
==========================================
  Files         205      205              
  Lines       23329    23341      +12     
==========================================
- Hits        16079    16030      -49     
- Misses       6141     6204      +63     
+ Partials     1109     1107       -2     
Flag Coverage Δ
unittests 68.67% <33.33%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/executor/resource_update_executor.go 29.57% <0.00%> (+0.41%) ⬆️
pkg/koordlet/resmanager/cgroup_reconcile.go 86.98% <100.00%> (+0.62%) ⬆️
...r/plugins/elasticquota/core/group_quota_manager.go 71.12% <0.00%> (-10.85%) ⬇️
pkg/scheduler/plugins/elasticquota/pod_handler.go 64.28% <0.00%> (-7.72%) ⬇️
pkg/scheduler/plugins/elasticquota/controller.go 72.30% <0.00%> (-3.70%) ⬇️
.../scheduler/plugins/elasticquota/core/quota_info.go 82.27% <0.00%> (-2.90%) ⬇️
pkg/scheduler/plugins/elasticquota/plugin.go 73.64% <0.00%> (-0.36%) ⬇️
...oordlet/runtimehooks/protocol/container_context.go 7.69% <0.00%> (-0.31%) ⬇️
.../scheduler/plugins/coscheduling/core/gang_cache.go 74.85% <0.00%> (+0.15%) ⬆️
pkg/scheduler/plugins/elasticquota/node_handler.go 67.69% <0.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: lucming <2876757716@qq.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@lucming 辛苦更新一下 PR 标题

@koordinator-bot koordinator-bot bot added the lgtm label Oct 24, 2022
@lucming lucming changed the title fix:the returned field has not been updated fix:delete unsed return args Oct 24, 2022
@jasonliu747 jasonliu747 changed the title fix:delete unsed return args fix: delete unused return args Oct 24, 2022
@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 32151cc into koordinator-sh:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants