Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in pkg/koordlet/metriccache/api.go #725

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

jasonliu747
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

pkg/koordlet/metriccache/api.go Show resolved Hide resolved
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 68.92% // Head: 68.89% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (767aa77) compared to base (22e9d78).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   68.92%   68.89%   -0.03%     
==========================================
  Files         205      205              
  Lines       23329    23329              
==========================================
- Hits        16079    16073       -6     
- Misses       6141     6149       +8     
+ Partials     1109     1107       -2     
Flag Coverage Δ
unittests 68.89% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
...eduler/plugins/coscheduling/controller/podgroup.go 70.29% <0.00%> (-1.99%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (-0.27%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit 272a3d2 into koordinator-sh:main Oct 20, 2022
@jasonliu747 jasonliu747 deleted the fix-typo branch October 20, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants