Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: optimize ElasticQuota plugin's update logic #729

Merged

Conversation

xulinfei1996
Copy link
Contributor

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #657

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 68.64% // Head: 68.61% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (90c7836) compared to base (9d20593).
Patch coverage: 45.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   68.64%   68.61%   -0.04%     
==========================================
  Files         205      205              
  Lines       23389    23439      +50     
==========================================
+ Hits        16056    16083      +27     
- Misses       6230     6244      +14     
- Partials     1103     1112       +9     
Flag Coverage Δ
unittests 68.61% <45.78%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/resexecutor/resource_executor.go 9.52% <0.00%> (ø)
pkg/runtimeproxy/utils/utils.go 100.00% <ø> (ø)
.../scheduler/plugins/elasticquota/core/quota_info.go 83.33% <ø> (+1.05%) ⬆️
pkg/runtimeproxy/resexecutor/cri/container.go 70.00% <26.66%> (-2.60%) ⬇️
pkg/runtimeproxy/resexecutor/cri/pod.go 72.54% <36.36%> (-4.05%) ⬇️
pkg/scheduler/plugins/elasticquota/controller.go 60.91% <46.66%> (-11.39%) ⬇️
...r/plugins/elasticquota/core/group_quota_manager.go 72.50% <60.00%> (+1.37%) ⬆️
pkg/runtimeproxy/resexecutor/cri/utils.go 87.90% <66.66%> (-1.67%) ⬇️
pkg/tools/cache/expiration_cache.go 75.75% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

@yihuifeng yihuifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, eahydra, yihuifeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eahydra eahydra added approved and removed approved labels Oct 28, 2022
@hormes hormes removed the request for review from FillZpp October 28, 2022 06:55
@koordinator-bot koordinator-bot bot merged commit 70ca982 into koordinator-sh:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] in elasticquota plugin,is the method syncHandler() update quota cr too frequently?
4 participants