-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apis: fix resctrl qos defaults #731
apis: fix resctrl qos defaults #731
Conversation
Codecov ReportBase: 68.64% // Head: 68.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 68.64% 68.59% -0.06%
==========================================
Files 205 205
Lines 23342 23342
==========================================
- Hits 16024 16012 -12
- Misses 6208 6219 +11
- Partials 1110 1111 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
also check other default values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
记得 charts 也要更新一下 |
Signed-off-by: saintube <saintube@foxmail.com>
f0422c9
to
a42637e
Compare
Done. |
haode |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Fixes the kubebuilder tags of Resctrl QoS to suppress BE pods' cache allocation and memory bandwidth by default.
Ⅱ. Does this pull request fix one issue?
Currently, the parameters of Resctrl QoS have been set kubebuilder tags
+kubebuilder:default=xxx
, which always sets some values (e.g. 100%) for the corresponding fields in NodeSLO if we do not specify these fields explicitly. This troubles the Resctrl settings for BE pods since when we only specifyResctrlQOS.Enable=true
, the real default values of BE pods (e.g. 30%) are overwrited.Ⅲ. Describe how to verify it
slo-controller-config
and enableResctrlQOS
for BE pods./sys/fs/resctrl/BE/schemata
if the L3 cache allocation and memory bandwidth are limited to 30%.Ⅳ. Special notes for reviews
V. Checklist
make test