Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: fix resctrl qos defaults #731

Merged

Conversation

saintube
Copy link
Member

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Fixes the kubebuilder tags of Resctrl QoS to suppress BE pods' cache allocation and memory bandwidth by default.

Ⅱ. Does this pull request fix one issue?

Currently, the parameters of Resctrl QoS have been set kubebuilder tags +kubebuilder:default=xxx, which always sets some values (e.g. 100%) for the corresponding fields in NodeSLO if we do not specify these fields explicitly. This troubles the Resctrl settings for BE pods since when we only specify ResctrlQOS.Enable=true, the real default values of BE pods (e.g. 30%) are overwrited.

Ⅲ. Describe how to verify it

  1. Prepare an Intel bare-metal machine that enables Intel RDT (L3 CAT & MBA) in the kernel command line.
  2. Edit slo-controller-config and enable ResctrlQOS for BE pods.
  3. Check /sys/fs/resctrl/BE/schemata if the L3 cache allocation and memory bandwidth are limited to 30%.

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube
Copy link
Member Author

cc @zwzhang0107 @jasonliu747

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 68.64% // Head: 68.59% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (a42637e) compared to base (a6559fb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   68.64%   68.59%   -0.06%     
==========================================
  Files         205      205              
  Lines       23342    23342              
==========================================
- Hits        16024    16012      -12     
- Misses       6208     6219      +11     
- Partials     1110     1111       +1     
Flag Coverage Δ
unittests 68.59% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

zwzhang0107 commented Oct 21, 2022

also check other default values

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jasonliu747
Copy link
Member

记得 charts 也要更新一下

Signed-off-by: saintube <saintube@foxmail.com>
@saintube
Copy link
Member Author

also check other default values

Done.

@saintube
Copy link
Member Author

记得 charts 也要更新一下

haode

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Oct 24, 2022
@hormes
Copy link
Member

hormes commented Oct 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 34b415c into koordinator-sh:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants