Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix throw Can't get node error during initialization #732

Conversation

JasonRD
Copy link
Contributor

@JasonRD JasonRD commented Oct 21, 2022

Ⅰ. Describe what this PR does

fix the Koordlet throw "Can't get node" during during initialization, when guessed driver failed from Cgroup name.

Ⅱ. Does this pull request fix one issue?

fixes #664

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…iver failed from cgroupname

Signed-off-by: jasonxie <jasonxie_rd@163.com>
@JasonRD JasonRD force-pushed the fix-koordlet-get-cgroup-by-kubelet branch from 72960ac to 3d2f077 Compare October 21, 2022 08:47
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 68.64% // Head: 68.63% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3d2f077) compared to base (a6559fb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   68.64%   68.63%   -0.02%     
==========================================
  Files         205      205              
  Lines       23342    23342              
==========================================
- Hits        16024    16021       -3     
- Misses       6208     6210       +2     
- Partials     1110     1111       +1     
Flag Coverage Δ
unittests 68.63% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Oct 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 247ee26 into koordinator-sh:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] koordlet throws Can't get node error during initialization
3 participants