Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update make deploy #736

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Oct 24, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Fix make deploy, which is convenient for developers to quickly deploy when testing and running E2E, and kustomize can also be used to generate chart files, including RBAC, etc., when releasing helm charts later.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra added this to the v1.0 milestone Oct 24, 2022
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 68.61% // Head: 68.69% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (c40adec) compared to base (15ab92c).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
+ Coverage   68.61%   68.69%   +0.07%     
==========================================
  Files         205      205              
  Lines       23346    23341       -5     
==========================================
+ Hits        16018    16033      +15     
+ Misses       6221     6205      -16     
+ Partials     1107     1103       -4     
Flag Coverage Δ
unittests 68.69% <33.33%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/executor/resource_update_executor.go 29.57% <0.00%> (+0.41%) ⬆️
...slo-controller/nodemetric/nodemetric_controller.go 56.00% <ø> (ø)
...controller/noderesource/noderesource_controller.go 44.92% <ø> (ø)
pkg/slo-controller/nodeslo/nodeslo_controller.go 49.16% <ø> (ø)
...hook/elasticquota/validating/validating_handler.go 74.13% <ø> (ø)
...webhook/pod/mutating/cluster_colocation_profile.go 55.97% <ø> (ø)
pkg/koordlet/resmanager/cgroup_reconcile.go 86.98% <100.00%> (+0.62%) ⬆️
...eduler/plugins/coscheduling/controller/podgroup.go 74.37% <0.00%> (+2.01%) ⬆️
pkg/koordlet/statesinformer/states_pods.go 56.73% <0.00%> (+2.12%) ⬆️
pkg/scheduler/plugins/elasticquota/controller.go 72.30% <0.00%> (+12.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jasonliu747
Copy link
Member

/assign

@zwzhang0107
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Oct 25, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit deccc9a into koordinator-sh:main Oct 25, 2022
kind: Kustomization
images:
- name: descheduler
newName: registry-vpc.cn-hangzhou.aliyuncs.com/koordinator-sh/koord-descheduler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry-vpc.cn-hangzhou.aliyuncs.com -> registry.cn-hangzhou.aliyuncs.com

newTag: latest
- name: manager
newName: registry-vpc.cn-hangzhou.aliyuncs.com/koordinator-sh/koord-manager
newTag: fix_make_deploy-e2e044cc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants