-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update make deploy #736
Conversation
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
2ac1de6
to
c40adec
Compare
Codecov ReportBase: 68.61% // Head: 68.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 68.61% 68.69% +0.07%
==========================================
Files 205 205
Lines 23346 23341 -5
==========================================
+ Hits 16018 16033 +15
+ Misses 6221 6205 -16
+ Partials 1107 1103 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/assign |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kind: Kustomization | ||
images: | ||
- name: descheduler | ||
newName: registry-vpc.cn-hangzhou.aliyuncs.com/koordinator-sh/koord-descheduler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registry-vpc.cn-hangzhou.aliyuncs.com
-> registry.cn-hangzhou.aliyuncs.com
newTag: latest | ||
- name: manager | ||
newName: registry-vpc.cn-hangzhou.aliyuncs.com/koordinator-sh/koord-manager | ||
newTag: fix_make_deploy-e2e044cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest?
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
Fix
make deploy
, which is convenient for developers to quickly deploy when testing and running E2E, andkustomize
can also be used to generate chart files, including RBAC, etc., when releasing helm charts later.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test