-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: fix for cpu suppress when node topology reporting disabled #737
koordlet: fix for cpu suppress when node topology reporting disabled #737
Conversation
Codecov ReportBase: 68.69% // Head: 68.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
+ Coverage 68.69% 68.70% +0.01%
==========================================
Files 205 205
Lines 23341 23356 +15
==========================================
+ Hits 16033 16047 +14
+ Misses 6205 6202 -3
- Partials 1103 1107 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f14058e
to
f8166ae
Compare
Signed-off-by: saintube <saintube@foxmail.com>
f8166ae
to
35db542
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Fix for CPU Suppress when koordlet disables NodeTopologyReport.
Ⅱ. Does this pull request fix one issue?
With this patch, nodeResourceTopology will be updated internally even if we set
NodeTopologyReport=false
in the feature-gates. It works when we want to enable CPU Suppress but disable NodeTopologyReport.May also fixes #730 .
Ⅲ. Describe how to verify it
BECPUSuppress=true,NodeTopologyReport=false
in the koordlet's feature-gates.Ⅳ. Special notes for reviews
V. Checklist
make test