Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix for cpu suppress when node topology reporting disabled #737

Conversation

saintube
Copy link
Member

@saintube saintube commented Oct 24, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Fix for CPU Suppress when koordlet disables NodeTopologyReport.

Ⅱ. Does this pull request fix one issue?

With this patch, nodeResourceTopology will be updated internally even if we set NodeTopologyReport=false in the feature-gates. It works when we want to enable CPU Suppress but disable NodeTopologyReport.

May also fixes #730 .

Ⅲ. Describe how to verify it

  1. Deploy koordinator.
  2. Set BECPUSuppress=true,NodeTopologyReport=false in the koordlet's feature-gates.
  3. Check if CPU Suppress works well.

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 68.69% // Head: 68.70% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (35db542) compared to base (32151cc).
Patch coverage: 63.02% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   68.69%   68.70%   +0.01%     
==========================================
  Files         205      205              
  Lines       23341    23356      +15     
==========================================
+ Hits        16033    16047      +14     
+ Misses       6205     6202       -3     
- Partials     1103     1107       +4     
Flag Coverage Δ
unittests 68.70% <63.02%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dlet/statesinformer/states_noderesourcetopology.go 65.14% <63.02%> (+4.53%) ⬆️
pkg/scheduler/plugins/elasticquota/controller.go 60.00% <0.00%> (-12.31%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️
pkg/slo-controller/nodeslo/nodeslo_controller.go 49.16% <0.00%> (ø)
...slo-controller/nodemetric/nodemetric_controller.go 56.00% <0.00%> (ø)
...hook/elasticquota/validating/validating_handler.go 74.13% <0.00%> (ø)
...controller/noderesource/noderesource_controller.go 44.92% <0.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saintube saintube force-pushed the fix-cpu-suppress-when-node-topo-not-reported branch from f14058e to f8166ae Compare October 25, 2022 02:08
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the fix-cpu-suppress-when-node-topo-not-reported branch from f8166ae to 35db542 Compare October 25, 2022 03:16
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Oct 25, 2022
@saintube saintube requested review from zwzhang0107 and removed request for stormgbs and jasonliu747 October 25, 2022 03:17
@zwzhang0107
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Oct 25, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 88df5a9 into koordinator-sh:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] koordlet UT failed when reporting topology
3 participants