koordlet: rm kubebuilder default tag for ResourceThresholdStrategy #741
Conversation
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
| @@ -156,8 +156,7 @@ const ( | |||
| ) | |||
|
|
|||
| type ResourceThresholdStrategy struct { | |||
| // whether the strategy is enabled, default = true | |||
| // +kubebuilder:default=true | |||
| // whether the strategy is enabled, default = false | |||
Codecov ReportBase: 68.74% // Head: 68.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 68.74% 68.73% -0.01%
==========================================
Files 205 205
Lines 23356 23356
==========================================
- Hits 16055 16053 -2
+ Misses 6200 6198 -2
- Partials 1101 1105 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: 佑祎 zzw261520@alibaba-inc.com
Ⅰ. Describe what this PR does
rm kubebuilder default tag in NodeSLO
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test