Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: change the required fields in ClusterColocationProfile to optional #751

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Oct 27, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

The user only wants to use ColocationProfile to change the schedulerName of the Pod. The original required field needs to be changed to optional.

Ⅱ. Does this pull request fix one issue?

fix #739

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra added this to the v1.0 milestone Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 68.42% // Head: 68.43% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a2893f9) compared to base (b6e9cda).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   68.42%   68.43%           
=======================================
  Files         205      205           
  Lines       23515    23515           
=======================================
+ Hits        16091    16093    +2     
- Misses       6309     6311    +2     
+ Partials     1115     1111    -4     
Flag Coverage Δ
unittests 68.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Oct 28, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot removed the lgtm label Oct 28, 2022
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@eahydra eahydra added the lgtm label Oct 28, 2022
@hormes hormes added approved and removed approved labels Oct 28, 2022
@koordinator-bot koordinator-bot bot merged commit c110da1 into koordinator-sh:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] ClusterColocationProfile's priorityClassName and qosClass should be optional
2 participants