RuntimeProxy: return err when FailurePolicyType set to Fail #754
Conversation
honpey
force-pushed
the
hook-server-policy
branch
from
787767e
to
0013dff
Compare
Codecov ReportBase: 68.64% // Head: 68.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
- Coverage 68.64% 68.41% -0.24%
==========================================
Files 205 208 +3
Lines 23389 23956 +567
==========================================
+ Hits 16056 16389 +333
- Misses 6230 6426 +196
- Partials 1103 1141 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -84,8 +84,9 @@ func (rd *RuntimeHookDispatcher) Dispatch(ctx context.Context, runtimeRequestPat | |||
| } | |||
| // currently, only one hook be called during one runtime | |||
| // TODO: multi hook server to merge response | |||
| return rd.dispatchInternal(ctx, hookType, client, request) | |||
| rsp, err := rd.dispatchInternal(ctx, hookType, client, request) | |||
| return rsp, err, hookServer.FailurePolicy | |||
There was a problem hiding this comment.
hookServer.FailurePolicy is this a required field or optional(with default)
There was a problem hiding this comment.
optional, if not set from config, default to PolicyNone
honpey
force-pushed
the
hook-server-policy
branch
from
0013dff
to
3296bc0
Compare
honpey
force-pushed
the
hook-server-policy
branch
from
3296bc0
to
db84953
Compare
Signed-off-by: honpey <honpey@gmail.com>
honpey
force-pushed
the
hook-server-policy
branch
from
db84953
to
46cb86e
Compare
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test