Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: runtime hook support failpolicy #773

Merged

Conversation

huiwq1990
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 67.50% // Head: 67.56% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (ca24657) compared to base (65849ae).
Patch coverage: 85.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
+ Coverage   67.50%   67.56%   +0.05%     
==========================================
  Files         241      246       +5     
  Lines       27982    28172     +190     
==========================================
+ Hits        18889    19034     +145     
- Misses       7793     7836      +43     
- Partials     1300     1302       +2     
Flag Coverage Δ
unittests 67.56% <85.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/runtimehooks.go 68.11% <72.72%> (-2.20%) ⬇️
pkg/koordlet/runtimehooks/config.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-4.12%) ⬇️
pkg/scheduler/plugins/loadaware/load_aware.go 73.81% <0.00%> (-3.28%) ⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go 77.28% <0.00%> (-0.95%) ⬇️
...ler/apis/config/validation/validation_loadaware.go 0.00% <0.00%> (ø)
pkg/descheduler/utils/anomaly/types.go 0.00% <0.00%> (ø)
pkg/scheduler/plugins/loadaware/estimator/types.go 0.00% <0.00%> (ø)
pkg/descheduler/utils/anomaly/basic_detector.go 89.24% <0.00%> (ø)
...r/plugins/loadaware/estimator/default_estimator.go 97.91% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Nov 24, 2022

@huiwq1990 What do you think about the above suggestion?

@huiwq1990
Copy link
Contributor Author

@hormes I just fix them.

@jasonliu747 jasonliu747 changed the title runtime hook support failpolicy koordlet: runtime hook support failpolicy Nov 30, 2022
if failPolicy == rmconfig.PolicyFail {
klog.Errorf("failed to run hook %s in stage %s, reason: %v", hook.name, stage, err)
return err
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need we use else condition? May log the warning message directly?

@zwzhang0107
Copy link
Contributor

/lgtm

Signed-off-by: huiwq1990 <huiwq1990@163.com>
@huiwq1990
Copy link
Contributor Author

@zwzhang0107 Why upload coverage to codecov failed?

@zwzhang0107
Copy link
Contributor

seems the network problem, can be fixed by retry

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Feb 8, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2e9b956 into koordinator-sh:main Feb 8, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants