koordlet: add runtime hook plugin batch resource #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 67.93% // Head: 67.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
==========================================
- Coverage 67.93% 67.57% -0.37%
==========================================
Files 216 218 +2
Lines 24381 24913 +532
==========================================
+ Hits 16564 16835 +271
- Misses 6668 6900 +232
- Partials 1149 1178 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
saintube
force-pushed
the
add-runtimehook-batch-resource
branch
2 times, most recently
from
297c837
to
135cc4c
Compare
saintube
changed the title
koordinator-bot
bot
added
area/koordlet
and removed
do-not-merge/work-in-progress
labels
saintube
force-pushed
the
add-runtimehook-batch-resource
branch
2 times, most recently
from
a2ce13d
to
16f72e7
Compare
zwzhang0107
reviewed
Nov 18, 2022
pkg/koordlet/runtimehooks/hooks/batchresource/batch_resource.go
Outdated
Show resolved
Hide resolved
saintube
force-pushed
the
add-runtimehook-batch-resource
branch
3 times, most recently
from
a73336b
to
9c69f68
Compare
zwzhang0107
reviewed
Nov 21, 2022
zwzhang0107
reviewed
Nov 21, 2022
saintube
force-pushed
the
add-runtimehook-batch-resource
branch
from
9c69f68
to
17f3f96
Compare
zwzhang0107
reviewed
Nov 22, 2022
pkg/koordlet/runtimehooks/hooks/batchresource/batch_resource.go
Outdated
Show resolved
Hide resolved
zwzhang0107
reviewed
Nov 22, 2022
zwzhang0107
reviewed
Nov 22, 2022
saintube
force-pushed
the
add-runtimehook-batch-resource
branch
from
17f3f96
to
d762806
Compare
Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
add-runtimehook-batch-resource
branch
from
d762806
to
0e5d063
Compare
|
/lgtm |
|
/approve |
1 similar comment
|
/approve |
|
/assign @FillZpp |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone v1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Add a runtime hook plugin named BatchResource to apply cpu/memory limitations for batch pods.
It will replace the old BEReconcile reconciler via runtime hook workflow.
Ⅱ. Does this pull request fix one issue?
fixes #717
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test