Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: fix typo error in framework_extender.go #775

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

KunWuLuan
Copy link
Contributor

Ⅰ. Describe what this PR does

typo: fix typo error in framework_extender.go

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 68.46% // Head: 68.44% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (37f3cbd) compared to base (885cfda).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   68.46%   68.44%   -0.03%     
==========================================
  Files         209      209              
  Lines       24062    24062              
==========================================
- Hits        16474    16469       -5     
- Misses       6444     6448       +4     
- Partials     1144     1145       +1     
Flag Coverage Δ
unittests 68.44% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/frameworkext/framework_extender.go 62.50% <100.00%> (ø)
pkg/scheduler/plugins/elasticquota/controller.go 51.72% <0.00%> (-9.20%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra
Copy link
Member

eahydra commented Nov 2, 2022

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eahydra eahydra changed the title typo: fix typo error in framework_extender.go koord-scheduler: fix typo error in framework_extender.go Nov 2, 2022
@koordinator-bot koordinator-bot bot merged commit bf60609 into koordinator-sh:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants