Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: query kubelet config via HTTP API #776

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Nov 2, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Currently, the configuration of the kubelet is obtained by parsing the kubelet command-line args and reusing the kubelet code, but this method currently has the problem of concurrent read and write race condition(issue #730 ). Now this PR uses the /configz API provided by kubelet to query the configuration. The disadvantage is that users can disable this API, which may bring some compatibility issues.

Ⅱ. Does this pull request fix one issue?

fix #730

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra force-pushed the query_kubelet_config_via_http branch from ade1164 to 7cc4131 Compare November 2, 2022 11:36
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the query_kubelet_config_via_http branch from 7cc4131 to 282e08c Compare November 2, 2022 11:41
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 68.46% // Head: 68.15% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (282e08c) compared to base (885cfda).
Patch coverage: 41.49% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   68.46%   68.15%   -0.31%     
==========================================
  Files         209      210       +1     
  Lines       24062    24084      +22     
==========================================
- Hits        16474    16415      -59     
- Misses       6444     6528      +84     
+ Partials     1144     1141       -3     
Flag Coverage Δ
unittests 68.15% <41.49%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...duler/plugins/elasticquota/quota_overuse_revoke.go 70.58% <0.00%> (-9.66%) ⬇️
pkg/scheduler/frameworkext/controllers.go 14.28% <14.28%> (ø)
pkg/scheduler/frameworkext/framework_extender.go 60.16% <16.66%> (-2.34%) ⬇️
pkg/scheduler/plugins/coscheduling/coscheduling.go 62.20% <23.80%> (-9.73%) ⬇️
pkg/koordlet/statesinformer/kubelet_stub.go 52.00% <40.00%> (-10.50%) ⬇️
...dlet/statesinformer/states_noderesourcetopology.go 63.98% <47.05%> (-1.16%) ⬇️
pkg/scheduler/plugins/elasticquota/controller.go 51.11% <60.00%> (-9.81%) ⬇️
pkg/scheduler/plugins/elasticquota/plugin.go 69.86% <66.66%> (-3.79%) ⬇️
...eduler/plugins/coscheduling/controller/podgroup.go 74.14% <77.77%> (-0.23%) ⬇️
pkg/util/kubelet/kubelet.go 56.28% <86.66%> (-2.25%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Nov 2, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2d5506c into koordinator-sh:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] koordlet UT failed when reporting topology
3 participants