-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: query kubelet config via HTTP API #776
koordlet: query kubelet config via HTTP API #776
Conversation
ade1164
to
7cc4131
Compare
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
7cc4131
to
282e08c
Compare
Codecov ReportBase: 68.46% // Head: 68.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 68.46% 68.15% -0.31%
==========================================
Files 209 210 +1
Lines 24062 24084 +22
==========================================
- Hits 16474 16415 -59
- Misses 6444 6528 +84
+ Partials 1144 1141 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
Currently, the configuration of the kubelet is obtained by parsing the kubelet command-line args and reusing the kubelet code, but this method currently has the problem of concurrent read and write race condition(issue #730 ). Now this PR uses the
/configz
API provided by kubelet to query the configuration. The disadvantage is that users can disable this API, which may bring some compatibility issues.Ⅱ. Does this pull request fix one issue?
fix #730
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test