-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: make webhookConfigurationName configurable #787
koord-manager: make webhookConfigurationName configurable #787
Conversation
Codecov ReportBase: 68.15% // Head: 68.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
=======================================
Coverage 68.15% 68.15%
=======================================
Files 210 210
Lines 24085 24085
=======================================
Hits 16416 16416
Misses 6528 6528
Partials 1141 1141
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
2a8c98b
to
89ad4ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: eahydra, FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.1 |
Signed-off-by: wangjianyu zmsjianyu@gmail.com
Ⅰ. Describe what this PR does
this PR make webhookConfigurationName configurable with env
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test