Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: exclude DefaultQuota and SystemQuota when updating quota tree #789

Merged

Conversation

xulinfei1996
Copy link
Contributor

@xulinfei1996 xulinfei1996 commented Nov 7, 2022

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

SystemQuotaInfo and DefaultQuotaInfo should not appear in runtimeQuotaCalculator.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 68.17% // Head: 68.15% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (3bcca01) compared to base (8065694).
Patch coverage: 30.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
- Coverage   68.17%   68.15%   -0.03%     
==========================================
  Files         210      210              
  Lines       24085    24088       +3     
==========================================
- Hits        16419    16416       -3     
- Misses       6525     6530       +5     
- Partials     1141     1142       +1     
Flag Coverage Δ
unittests 68.15% <30.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/plugins/elasticquota/core/group_quota_manager.go 72.10% <30.00%> (-0.45%) ⬇️
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ly appears defaultQuotaName and SystemQuotaName

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
@koordinator-bot koordinator-bot bot added size/S and removed size/XS labels Nov 8, 2022
@eahydra eahydra changed the title koord-scheduler: fix elasticQuota root RuntimeCalculator's unexpected… koord-scheduler: exclude DefaultQuota and SystemQuota when updating quota tree Nov 9, 2022
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 3b36c0c into koordinator-sh:main Nov 10, 2022
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants