-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split util/pod.go by function #792
Conversation
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Codecov ReportBase: 68.15% // Head: 68.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
+ Coverage 68.15% 68.19% +0.04%
==========================================
Files 210 211 +1
Lines 24102 24102
==========================================
+ Hits 16427 16437 +10
+ Misses 6535 6526 -9
+ Partials 1140 1139 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
||
apiext "github.com/koordinator-sh/koordinator/apis/extension" | ||
) | ||
|
||
// NOTE: functions in this file can be overwrite for extension | ||
// NOTE: functions in this file can be overwritten for extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
英语满分💯
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jasonliu747, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.1 |
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
Splitting util/pod.go by function is easy to maintain.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test