Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split util/pod.go by function #792

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Nov 8, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Splitting util/pod.go by function is easy to maintain.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 68.15% // Head: 68.19% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (3fc210f) compared to base (f653e7e).
Patch coverage: 59.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
+ Coverage   68.15%   68.19%   +0.04%     
==========================================
  Files         210      211       +1     
  Lines       24102    24102              
==========================================
+ Hits        16427    16437      +10     
+ Misses       6535     6526       -9     
+ Partials     1140     1139       -1     
Flag Coverage Δ
unittests 68.19% <59.77%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/pod.go 44.31% <ø> (-8.29%) ⬇️
pkg/util/pod_resources_utils.go 58.22% <58.22%> (ø)
pkg/util/pod_qos_utils.go 60.00% <75.00%> (+26.66%) ⬆️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+7.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/util/pod_resources_utils.go Show resolved Hide resolved
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


apiext "github.com/koordinator-sh/koordinator/apis/extension"
)

// NOTE: functions in this file can be overwrite for extension
// NOTE: functions in this file can be overwritten for extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英语满分💯

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jasonliu747, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 650dcd2 into koordinator-sh:main Nov 9, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants