Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: pod mutating handler add extended resource spec #797

Merged

Conversation

saintube
Copy link
Member

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Update pod mutating webhook to add a pod annotation of extended resource spec.

Ⅱ. Does this pull request fix one issue?

Partially for #717.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube saintube force-pushed the add-extended-resource-webhook branch 2 times, most recently from a110b8f to 78763e5 Compare November 10, 2022 10:52
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 68.12% // Head: 68.11% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4d37ba4) compared to base (10f8e50).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   68.12%   68.11%   -0.02%     
==========================================
  Files         212      213       +1     
  Lines       24115    24178      +63     
==========================================
+ Hits        16429    16468      +39     
- Misses       6551     6565      +14     
- Partials     1135     1145      +10     
Flag Coverage Δ
unittests 68.11% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webhook/pod/mutating/cluster_colocation_profile.go 55.97% <ø> (ø)
pkg/webhook/pod/mutating/mutating_handler.go 68.18% <0.00%> (-6.82%) ⬇️
pkg/webhook/pod/mutating/extended_resource_spec.go 71.18% <71.18%> (ø)
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saintube saintube force-pushed the add-extended-resource-webhook branch from 78763e5 to 6deabfa Compare November 10, 2022 12:34
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the add-extended-resource-webhook branch from 6deabfa to 4d37ba4 Compare November 10, 2022 13:18
@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 80ec3cb into koordinator-sh:main Nov 10, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants