Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: update Enhanced Scheduler Extension #798

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Nov 11, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Update overview image and add comment to Hook

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 67.91% // Head: 67.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e5778a0) compared to base (39cb1d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   67.91%   67.90%   -0.01%     
==========================================
  Files         216      216              
  Lines       24368    24368              
==========================================
- Hits        16549    16548       -1     
  Misses       6675     6675              
- Partials     1144     1145       +1     
Flag Coverage Δ
unittests 67.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️
...eduler/plugins/coscheduling/controller/podgroup.go 72.19% <0.00%> (-1.96%) ⬇️
pkg/util/httputil/reverseproxy.go 85.37% <0.00%> (+0.53%) ⬆️
pkg/koordlet/statesinformer/states_pods.go 56.73% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Nov 11, 2022

image

As we discussed, it actually belongs to a transformation inside the scheduling process, adjusted in place in one step?

@eahydra eahydra force-pushed the update_scheduler_extension_doc branch 2 times, most recently from 8155fcf to f189b18 Compare November 11, 2022 08:32
@eahydra
Copy link
Member Author

eahydra commented Nov 11, 2022

image

As we discussed, it actually belongs to a transformation inside the scheduling process, adjusted in place in one step?

updated

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the update_scheduler_extension_doc branch from f189b18 to e5778a0 Compare November 11, 2022 11:31
@hormes
Copy link
Member

hormes commented Nov 14, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 9ebead3 into koordinator-sh:main Nov 14, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants