Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed quota deep copy and cyclestate #799

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

fjding
Copy link
Contributor

@fjding fjding commented Nov 12, 2022

Signed-off-by: fjding dingfangjie@bytedance.com

Ⅰ. Describe what this PR does

fixed quota deep copy and cyclestate

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: fjding <dingfangjie@bytedance.com>
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 67.91% // Head: 67.93% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a200c00) compared to base (39cb1d1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   67.91%   67.93%   +0.01%     
==========================================
  Files         216      216              
  Lines       24368    24372       +4     
==========================================
+ Hits        16549    16556       +7     
+ Misses       6675     6668       -7     
- Partials     1144     1148       +4     
Flag Coverage Δ
unittests 67.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../scheduler/plugins/elasticquota/core/quota_info.go 83.81% <100.00%> (+0.48%) ⬆️
pkg/scheduler/plugins/elasticquota/plugin.go 72.02% <100.00%> (+2.16%) ⬆️
...kg/scheduler/plugins/elasticquota/plugin_helper.go 78.57% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️
pkg/koordlet/statesinformer/states_pods.go 56.73% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes hormes requested a review from buptcozy November 14, 2022 10:08
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Nov 15, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit bfc4c9a into koordinator-sh:main Nov 15, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants