-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OWNERS files for approvers definition and update community docs #801
Add OWNERS files for approvers definition and update community docs #801
Conversation
Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
5706671
to
a36f5e2
Compare
/cc @hormes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有 alias 了,但貌似没有具体同学的名单
@jasonliu747 I expect those approvers could post PRs to add them into the approver alias, or I can complete the alias for all of them. Which one do you think is better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FillZpp sure, SGTM.
/lgtm
Codecov ReportBase: 67.91% // Head: 67.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
+ Coverage 67.91% 67.92% +0.01%
==========================================
Files 216 216
Lines 24368 24368
==========================================
+ Hits 16549 16553 +4
+ Misses 6675 6668 -7
- Partials 1144 1147 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Siyu Wang FillZpp.pub@gmail.com
Ⅰ. Describe what this PR does
Add OWNERS files for approvers definition and update community docs.