Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS files for approvers definition and update community docs #801

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Nov 14, 2022

Signed-off-by: Siyu Wang FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Add OWNERS files for approvers definition and update community docs.

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
@FillZpp
Copy link
Member Author

FillZpp commented Nov 14, 2022

/cc @hormes

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有 alias 了,但貌似没有具体同学的名单

@FillZpp
Copy link
Member Author

FillZpp commented Nov 14, 2022

@jasonliu747 I expect those approvers could post PRs to add them into the approver alias, or I can complete the alias for all of them. Which one do you think is better?

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FillZpp sure, SGTM.
/lgtm

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 67.91% // Head: 67.92% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a36f5e2) compared to base (39cb1d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
+ Coverage   67.91%   67.92%   +0.01%     
==========================================
  Files         216      216              
  Lines       24368    24368              
==========================================
+ Hits        16549    16553       +4     
+ Misses       6675     6668       -7     
- Partials     1144     1147       +3     
Flag Coverage Δ
unittests 67.92% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️
pkg/util/httputil/reverseproxy.go 85.63% <0.00%> (+0.79%) ⬆️
pkg/koordlet/statesinformer/states_pods.go 56.73% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Nov 14, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit fba5de8 into koordinator-sh:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants