Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FillZpp into approvers alias #802

Merged

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Nov 14, 2022

Signed-off-by: Siyu Wang FillZpp.pub@gmail.com

Ⅰ. Describe what this PR does

Add FillZpp into approvers alias:

  • api-machinery-approvers
  • descheduler-approvers
  • webhook-approvers

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 67.90% // Head: 67.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (24cae7c) compared to base (fba5de8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   67.90%   67.90%   -0.01%     
==========================================
  Files         216      216              
  Lines       24368    24368              
==========================================
- Hits        16548    16547       -1     
- Misses       6672     6677       +5     
+ Partials     1148     1144       -4     
Flag Coverage Δ
unittests 67.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Nov 14, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 29d3143 into koordinator-sh:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants