-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-descheduler: evict pod by perferred groupverison #811
koord-descheduler: evict pod by perferred groupverison #811
Conversation
Codecov ReportBase: 67.92% // Head: 67.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 67.92% 67.89% -0.03%
==========================================
Files 216 216
Lines 24376 24380 +4
==========================================
- Hits 16557 16554 -3
- Misses 6671 6676 +5
- Partials 1148 1150 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
132a01b
to
d94fd83
Compare
d94fd83
to
9f5e040
Compare
pkg/descheduler/controllers/migration/evictor/evictor_native.go
Outdated
Show resolved
Hide resolved
/lgtm Thanks @LeoLiuYan |
9f5e040
to
7d6417d
Compare
7d6417d
to
13d8076
Compare
/retest |
@LeoLiuYan: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: LeoLiuYan <929908264@qq.com>
13d8076
to
1adfe27
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.1 |
Signed-off-by: LeoLiuYan 929908264@qq.com
Ⅰ. Describe what this PR does
Find out the server if support eviction subresource and use preferred groupversion.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test