Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: evict pod by perferred groupverison #811

Conversation

LeoLiuYan
Copy link
Contributor

Signed-off-by: LeoLiuYan 929908264@qq.com

Ⅰ. Describe what this PR does

Find out the server if support eviction subresource and use preferred groupversion.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [✅] I have written necessary docs and comments
  • [✅] I have added necessary unit tests and integration tests
  • [✅] All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 67.92% // Head: 67.89% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1adfe27) compared to base (3928264).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   67.92%   67.89%   -0.03%     
==========================================
  Files         216      216              
  Lines       24376    24380       +4     
==========================================
- Hits        16557    16554       -3     
- Misses       6671     6676       +5     
- Partials     1148     1150       +2     
Flag Coverage Δ
unittests 67.89% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/descheduler/evictions/evictions.go 91.08% <100.00%> (+0.18%) ⬆️
...eduler/plugins/coscheduling/controller/podgroup.go 72.19% <0.00%> (-1.96%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeoLiuYan LeoLiuYan force-pushed the feat/evictpod_by_preferred_groupversion branch from 132a01b to d94fd83 Compare November 16, 2022 07:51
@LeoLiuYan LeoLiuYan force-pushed the feat/evictpod_by_preferred_groupversion branch from d94fd83 to 9f5e040 Compare November 16, 2022 10:21
@FillZpp
Copy link
Member

FillZpp commented Nov 17, 2022

/lgtm

Thanks @LeoLiuYan

@koordinator-bot koordinator-bot bot added the lgtm label Nov 17, 2022
@LeoLiuYan LeoLiuYan force-pushed the feat/evictpod_by_preferred_groupversion branch from 9f5e040 to 7d6417d Compare November 17, 2022 08:56
@koordinator-bot koordinator-bot bot removed the lgtm label Nov 17, 2022
@LeoLiuYan LeoLiuYan force-pushed the feat/evictpod_by_preferred_groupversion branch from 7d6417d to 13d8076 Compare November 17, 2022 13:06
@LeoLiuYan
Copy link
Contributor Author

/retest

@koordinator-bot
Copy link

@LeoLiuYan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: LeoLiuYan <929908264@qq.com>
@LeoLiuYan LeoLiuYan force-pushed the feat/evictpod_by_preferred_groupversion branch from 13d8076 to 1adfe27 Compare November 17, 2022 14:10
@LeoLiuYan LeoLiuYan requested review from FillZpp and eahydra and removed request for FillZpp November 18, 2022 01:56
@FillZpp
Copy link
Member

FillZpp commented Nov 18, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Nov 18, 2022
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a35cfe8 into koordinator-sh:main Nov 18, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants