-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add flag to support disable querying kubelet configuration #814
koordlet: add flag to support disable querying kubelet configuration #814
Conversation
/area koordlet |
Codecov ReportBase: 67.93% // Head: 67.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
- Coverage 67.93% 67.89% -0.04%
==========================================
Files 216 216
Lines 24372 24376 +4
==========================================
- Hits 16556 16549 -7
- Misses 6667 6682 +15
+ Partials 1149 1145 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
5979889
to
b3832c2
Compare
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
b3832c2
to
29c0099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.1 |
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
fix #815 , add flag to support disable querying kubelet configuration.
This is a short-term workaround. I will remove this flag after thinking of a better solution.
V. Checklist
make test