Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add flag to support disable querying kubelet configuration #814

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Nov 15, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

fix #815 , add flag to support disable querying kubelet configuration.
This is a short-term workaround. I will remove this flag after thinking of a better solution.

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@jasonliu747
Copy link
Member

/area koordlet

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 67.93% // Head: 67.89% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (29c0099) compared to base (4470098).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   67.93%   67.89%   -0.04%     
==========================================
  Files         216      216              
  Lines       24372    24376       +4     
==========================================
- Hits        16556    16549       -7     
- Misses       6667     6682      +15     
+ Partials     1149     1145       -4     
Flag Coverage Δ
unittests 67.89% <80.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dlet/statesinformer/states_noderesourcetopology.go 63.25% <77.77%> (-0.73%) ⬇️
pkg/koordlet/statesinformer/config.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (ø)
...eduler/plugins/coscheduling/controller/podgroup.go 74.14% <0.00%> (+1.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra force-pushed the support_disable_query_kubelet_configuration branch from 5979889 to b3832c2 Compare November 16, 2022 03:56
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Nov 16, 2022
@eahydra eahydra changed the title koordlet: support disable querying kubelet configuration flag koordlet: add flag to support disable querying kubelet configuration Nov 16, 2022
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the support_disable_query_kubelet_configuration branch from b3832c2 to 29c0099 Compare November 16, 2022 05:48
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 6fdcf15 into koordinator-sh:main Nov 16, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] configured koordlet with kubelet insecure port, koordlet failed to query kubelet configuration
4 participants