Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: fix elasticQuota ut fail #819

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

xulinfei1996
Copy link
Contributor

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

查看了抢占UT失败的原因,SystemQuota或者DefaultQuota在测试的两个Quota组Add之后才触发了OnQuotaAdd事件。在重建树的时候,测试的两个quota组的runtimeQuota会被erase,但又没有触发refreshRuntimeQuota的时间,所以runtimeQuota为0。对于UT的解法,先加载SystemQuota以及DefaultQuota,再开始测试。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xulinfei1996 测试失败的日志可以上传一下

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 67.91% // Head: 67.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3bfa06e) compared to base (d3b92f1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   67.91%   67.90%   -0.01%     
==========================================
  Files         216      216              
  Lines       24376    24381       +5     
==========================================
+ Hits        16555    16557       +2     
- Misses       6671     6675       +4     
+ Partials     1150     1149       -1     
Flag Coverage Δ
unittests 67.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/elasticquota/plugin.go 72.22% <100.00%> (+0.19%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/descheduler/evictions/evictions.go 91.08% <0.00%> (+0.18%) ⬆️
...eduler/plugins/coscheduling/controller/podgroup.go 74.14% <0.00%> (+1.95%) ⬆️
...kg/scheduler/plugins/elasticquota/plugin_helper.go 80.61% <0.00%> (+2.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xulinfei1996
Copy link
Contributor Author

11_Run Go test(1).txt

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
@eahydra
Copy link
Member

eahydra commented Nov 22, 2022

/lgtm

@eahydra
Copy link
Member

eahydra commented Nov 22, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Nov 22, 2022
@koordinator-bot koordinator-bot bot merged commit 9ff814a into koordinator-sh:main Nov 22, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants