-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: fix elasticQuota ut fail #819
koord-scheduler: fix elasticQuota ut fail #819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xulinfei1996 测试失败的日志可以上传一下
Codecov ReportBase: 67.91% // Head: 67.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
- Coverage 67.91% 67.90% -0.01%
==========================================
Files 216 216
Lines 24376 24381 +5
==========================================
+ Hits 16555 16557 +2
- Misses 6671 6675 +4
+ Partials 1150 1149 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
f8cd958
to
3bfa06e
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/milestone v1.1 |
Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com
Ⅰ. Describe what this PR does
查看了抢占UT失败的原因,SystemQuota或者DefaultQuota在测试的两个Quota组Add之后才触发了OnQuotaAdd事件。在重建树的时候,测试的两个quota组的runtimeQuota会被erase,但又没有触发refreshRuntimeQuota的时间,所以runtimeQuota为0。对于UT的解法,先加载SystemQuota以及DefaultQuota,再开始测试。
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test