Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: make initialization scalable #832

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Nov 23, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Maintain plugin list separately for easy expansion.

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@ZiMengSheng
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 67.95% // Head: 67.90% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (5e470bc) compared to base (b401d54).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   67.95%   67.90%   -0.06%     
==========================================
  Files         216      216              
  Lines       24387    24387              
==========================================
- Hits        16573    16560      -13     
- Misses       6666     6678      +12     
- Partials     1148     1149       +1     
Flag Coverage Δ
unittests 67.90% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title koord-scheduler: maintain plugin list separately for easy expansion koord-scheduler: make initialization scalable Nov 23, 2022
@eahydra eahydra removed the request for review from FillZpp November 23, 2022 15:28
@koordinator-sh koordinator-sh deleted a comment from koordinator-bot bot Nov 23, 2022
@koordinator-sh koordinator-sh deleted a comment from koordinator-bot bot Nov 23, 2022
@eahydra eahydra requested review from FillZpp and removed request for yihuifeng November 23, 2022 15:29
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e9ad0c3 into koordinator-sh:main Nov 24, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants