Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: ElasticQuota uses Pod Namespace/Name as cache key #841

Merged

Conversation

xulinfei1996
Copy link
Contributor

@xulinfei1996 xulinfei1996 commented Nov 28, 2022

Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com

Ⅰ. Describe what this PR does

Use pod.Namesapce/Name as the key of the QuotaInfo's PodCache instead of pod.Name.

Ⅱ. Does this pull request fix one issue?

fix #839

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…Cache

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 67.47% // Head: 67.52% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (ed81e25) compared to base (9766c24).
Patch coverage: 79.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   67.47%   67.52%   +0.05%     
==========================================
  Files         219      219              
  Lines       24988    24993       +5     
==========================================
+ Hits        16860    16876      +16     
+ Misses       6953     6940      -13     
- Partials     1175     1177       +2     
Flag Coverage Δ
unittests 67.52% <79.16%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/elasticquota/plugin.go 70.14% <50.00%> (ø)
.../scheduler/plugins/elasticquota/core/quota_info.go 82.47% <80.00%> (+0.35%) ⬆️
...r/plugins/elasticquota/core/group_quota_manager.go 72.67% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+1.06%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (+4.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra added this to the v1.1 milestone Nov 29, 2022
@eahydra eahydra changed the title koord-scheduler: use pod Namespace/Name as the key of quotaInfo's pod… koord-scheduler: use Pod Namespace/Name as cache key in ElasticQuota Nov 29, 2022
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Nov 29, 2022
@eahydra eahydra changed the title koord-scheduler: use Pod Namespace/Name as cache key in ElasticQuota koord-scheduler: ElasticQuota uses Pod Namespace/Name as cache key Nov 29, 2022
@eahydra
Copy link
Member

eahydra commented Nov 30, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 9b605fa into koordinator-sh:main Nov 30, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ElasticQuota uses Pod Name as Cache Key
3 participants