koord-scheduler: LoadAware supports load scheduling by Prod Pods #843

eahydra · 2022-11-28T10:07:54Z

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Supports filter nodes by ProdUsageThresholds that defined in the config of scheduler or the annotation of nodes.
The ProdUsageThresholds indicates the resource utilization threshold of Prod Pods compared to the whole machine.
Not enable filter usage by ProdUsageThresholds by default.
When scoring, estimate the usage of the recently scheduled Prod Pod or take the Pod usage reported by NodeMetric, and calculate the load water level of the Prod Pod after accumulating the total amount. The lower the water level, the higher the score.

Ⅱ. Does this pull request fix one issue?

fix #314.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

I have written necessary docs and comments
I have added necessary unit tests and integration tests
All checks passed in make test

eahydra · 2022-11-28T10:08:30Z

/hold

codecov · 2022-11-28T10:19:49Z

Codecov Report

Base: 66.45% // Head: 66.51% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (8020298) compared to base (4c843e3).
Patch coverage: 81.75% of modified lines in pull request are covered.

❗ Current head 8020298 differs from pull request most recent head 86203d2. Consider uploading reports for the commit 86203d2 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
+ Coverage   66.45%   66.51%   +0.05%     
==========================================
  Files         233      234       +1     
  Lines       26512    26614     +102     
==========================================
+ Hits        17618    17701      +83     
- Misses       7665     7672       +7     
- Partials     1229     1241      +12

Flag	Coverage Δ
unittests	`66.51% <81.75%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/scheduler/plugins/loadaware/load_aware.go	`74.02% <79.06%> (-1.24%)`	⬇️
pkg/scheduler/plugins/loadaware/helper.go	`86.27% <86.27%> (ø)`
...heduler/frameworkext/helper/synced_eventhandler.go	`75.75% <0.00%> (-7.88%)`	⬇️
pkg/util/httputil/reverseproxy.go	`84.84% <0.00%> (ø)`
pkg/koordlet/resmanager/resmanager.go	`54.33% <0.00%> (ø)`
pkg/tools/cache/expiration_cache.go
pkg/util/cache/expiration_cache.go	`75.75% <0.00%> (ø)`
pkg/koordlet/resmanager/cpu_evict.go	`74.50% <0.00%> (+0.38%)`	⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go	`65.88% <0.00%> (+4.11%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/scheduler/plugins/loadaware/load_aware.go

eahydra · 2022-12-10T10:26:56Z

/hold cancel

eahydra · 2022-12-10T10:41:18Z

/milestone v1.1

saintube · 2022-12-12T06:13:56Z

/lgtm

jasonliu747 · 2022-12-12T08:37:48Z

/assign

pkg/scheduler/plugins/loadaware/load_aware.go

Signed-off-by: Joseph <joseph.t.lee@outlook.com>

ZiMengSheng · 2022-12-12T11:34:56Z

/lgtm

saintube · 2022-12-12T13:00:41Z

/lgtm

eahydra · 2022-12-12T15:08:01Z

/approve

FillZpp

/lgtm

koordinator-bot · 2022-12-13T02:27:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~apis/OWNERS~~ [FillZpp]
~~pkg/scheduler/OWNERS~~ [eahydra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jasonliu747

great work as always.

jasonliu747 · 2022-12-13T06:51:59Z

pkg/scheduler/plugins/loadaware/helper.go

+	return time.Duration(*nodeMetric.Spec.CollectPolicy.ReportIntervalSeconds) * time.Second
+}
+
+func getPodNamespacedName(namespace, name string) string {


这个函数貌似在许多插件里都实现了一次，我们有空的时候或许可以把他扔进util里。

是的。确实可以把一些函数挪到util的。

koordinator-bot bot requested review from buptcozy and FillZpp November 28, 2022 10:08

koordinator-bot bot added the size/L label Nov 28, 2022

eahydra requested review from hormes, saintube, ZiMengSheng and zwzhang0107 November 28, 2022 10:08

koordinator-bot bot added the do-not-merge/hold label Nov 28, 2022

eahydra force-pushed the loadaware_scheduling_support_prod_pods branch from 89d9c2a to 492e912 Compare November 28, 2022 17:41

saintube reviewed Nov 29, 2022

View reviewed changes

pkg/scheduler/plugins/loadaware/load_aware.go Show resolved Hide resolved

pkg/scheduler/plugins/loadaware/load_aware.go Show resolved Hide resolved

eahydra force-pushed the loadaware_scheduling_support_prod_pods branch from 492e912 to 75e4846 Compare December 10, 2022 10:26

koordinator-bot bot added size/XL and removed size/L labels Dec 10, 2022

koordinator-bot bot removed the do-not-merge/hold label Dec 10, 2022

eahydra requested a review from saintube December 10, 2022 10:27

koordinator-bot bot added this to the v1.1 milestone Dec 10, 2022

koordinator-bot bot assigned saintube Dec 12, 2022

koordinator-bot bot added the lgtm label Dec 12, 2022

eahydra requested a review from jasonliu747 December 12, 2022 08:25

koordinator-bot bot assigned jasonliu747 Dec 12, 2022

ZiMengSheng reviewed Dec 12, 2022

View reviewed changes

pkg/scheduler/plugins/loadaware/load_aware.go Show resolved Hide resolved

eahydra force-pushed the loadaware_scheduling_support_prod_pods branch from 75e4846 to 8020298 Compare December 12, 2022 11:07

koordinator-bot bot removed the lgtm label Dec 12, 2022

eahydra requested a review from ZiMengSheng December 12, 2022 11:08

koord-scheduler: LoadAware supports load scheduling by Prod Pods

86203d2

Signed-off-by: Joseph <joseph.t.lee@outlook.com>

eahydra force-pushed the loadaware_scheduling_support_prod_pods branch from 8020298 to 86203d2 Compare December 12, 2022 11:11

ZiMengSheng approved these changes Dec 12, 2022

View reviewed changes

koordinator-bot bot assigned ZiMengSheng Dec 12, 2022

koordinator-bot bot added the lgtm label Dec 12, 2022

FillZpp approved these changes Dec 13, 2022

View reviewed changes

koordinator-bot bot assigned FillZpp Dec 13, 2022

koordinator-bot bot added the approved label Dec 13, 2022

koordinator-bot bot merged commit a2aed08 into koordinator-sh:main Dec 13, 2022

jasonliu747 reviewed Dec 13, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

koord-scheduler: LoadAware supports load scheduling by Prod Pods #843

koord-scheduler: LoadAware supports load scheduling by Prod Pods #843

eahydra commented Nov 28, 2022 •

edited

Loading

eahydra commented Nov 28, 2022

codecov bot commented Nov 28, 2022 •

edited

Loading

eahydra commented Dec 10, 2022

eahydra commented Dec 10, 2022

saintube commented Dec 12, 2022

jasonliu747 commented Dec 12, 2022

ZiMengSheng commented Dec 12, 2022

saintube commented Dec 12, 2022

eahydra commented Dec 12, 2022

FillZpp left a comment

koordinator-bot bot commented Dec 13, 2022

jasonliu747 left a comment

jasonliu747 Dec 13, 2022

eahydra Dec 13, 2022

koord-scheduler: LoadAware supports load scheduling by Prod Pods #843

koord-scheduler: LoadAware supports load scheduling by Prod Pods #843

Conversation

eahydra commented Nov 28, 2022 • edited Loading

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

eahydra commented Nov 28, 2022

codecov bot commented Nov 28, 2022 • edited Loading

Codecov Report

eahydra commented Dec 10, 2022

eahydra commented Dec 10, 2022

saintube commented Dec 12, 2022

jasonliu747 commented Dec 12, 2022

ZiMengSheng commented Dec 12, 2022

saintube commented Dec 12, 2022

eahydra commented Dec 12, 2022

FillZpp left a comment

Choose a reason for hiding this comment

koordinator-bot bot commented Dec 13, 2022

jasonliu747 left a comment

Choose a reason for hiding this comment

jasonliu747 Dec 13, 2022

Choose a reason for hiding this comment

eahydra Dec 13, 2022

Choose a reason for hiding this comment

eahydra commented Nov 28, 2022 •

edited

Loading

codecov bot commented Nov 28, 2022 •

edited

Loading