Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: support log filtering failure reasons as needed #847

Merged

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Nov 29, 2022

Signed-off-by: wangjianyu zmsjianyu@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

this PR solves issue #846

Ⅲ. Describe how to verify it

image

Ⅳ. Special notes for reviews

V. Checklist

  • [] I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra changed the title koord-scheduler: log filter status koord-scheduler: support log filter failed reason Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 67.65% // Head: 67.61% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (cd3cb3c) compared to base (2a905d1).
Patch coverage: 69.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   67.65%   67.61%   -0.05%     
==========================================
  Files         224      224              
  Lines       25561    25573      +12     
==========================================
- Hits        17293    17290       -3     
- Misses       7071     7081      +10     
- Partials     1197     1202       +5     
Flag Coverage Δ
unittests 67.61% <69.23%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/frameworkext/framework_extender.go 59.01% <40.00%> (-1.16%) ⬇️
pkg/scheduler/frameworkext/debug.go 86.44% <87.50%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-5.30%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title koord-scheduler: support log filter failed reason koord-scheduler: support log filtering failure reasons Nov 29, 2022
@eahydra eahydra changed the title koord-scheduler: support log filtering failure reasons koord-scheduler: support filtering log failure reasons as needed Nov 29, 2022
@eahydra eahydra changed the title koord-scheduler: support filtering log failure reasons as needed koord-scheduler: support log filtering failure reasons as needed Nov 29, 2022
@eahydra eahydra linked an issue Nov 29, 2022 that may be closed by this pull request
Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eahydra
Copy link
Member

eahydra commented Nov 30, 2022

/lgtm
/approve

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 9801432 into koordinator-sh:main Nov 30, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
@ZiMengSheng ZiMengSheng deleted the support_filter_logs branch January 13, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] scheduler support filter logs
4 participants