Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): bump github.com/fsnotify/fsnotify from 1.5.4 to 1.6.0 #849

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 29, 2022

Bumps github.com/fsnotify/fsnotify from 1.5.4 to 1.6.0.

Release notes

Sourced from github.com/fsnotify/fsnotify's releases.

v1.6.0

This version of fsnotify needs Go 1.16 (this was already the case since 1.5.1, but not documented). It also increases the minimum Linux version to 2.6.32.

Additions

  • all: add Event.Has() and Op.Has() (#477)

    This makes checking events a lot easier; for example:

    if event.Op&Write == Write && !(event.Op&Remove == Remove) {
    }
    

    Becomes:

    if event.Has(Write) && !event.Has(Remove) {
    }
    
  • all: add cmd/fsnotify (#463)

    A command-line utility for testing and some examples.

Changes and fixes

  • inotify: don't ignore events for files that don't exist (#260, #470)

    Previously the inotify watcher would call os.Lstat() to check if a file still exists before emitting events.

    This was inconsistent with other platforms and resulted in inconsistent event reporting (e.g. when a file is quickly removed and re-created), and generally a source of confusion. It was added in 2013 to fix a memory leak that no longer exists.

  • all: return ErrNonExistentWatch when Remove() is called on a path that's not watched (#460)

  • inotify: replace epoll() with non-blocking inotify (#434)

    Non-blocking inotify was not generally available at the time this library was written in 2014, but now it is. As a result, the minimum Linux version is bumped from 2.6.27 to 2.6.32. This hugely simplifies the code and is faster.

  • kqueue: don't check for events every 100ms (#480)

    The watcher would wake up every 100ms, even when there was nothing to do. Now it waits until there is something to do.

  • macos: retry opening files on EINTR (#475)

  • kqueue: skip unreadable files (#479)

    kqueue requires a file descriptor for every file in a directory; this would fail if a file was unreadable by the current user. Now these files are simply skipped.

  • windows: fix renaming a watched directory if the parent is also watched (#370)

  • windows: increase buffer size from 4K to 64K (#485)

... (truncated)

Changelog

Sourced from github.com/fsnotify/fsnotify's changelog.

1.6.0 - 2022-10-13

This version of fsnotify needs Go 1.16 (this was already the case since 1.5.1, but not documented). It also increases the minimum Linux version to 2.6.32.

Additions

  • all: add Event.Has() and Op.Has() (#477)

    This makes checking events a lot easier; for example:

    if event.Op&Write == Write && !(event.Op&Remove == Remove) {
    }
    

    Becomes:

    if event.Has(Write) && !event.Has(Remove) {
    }
    
  • all: add cmd/fsnotify (#463)

    A command-line utility for testing and some examples.

Changes and fixes

  • inotify: don't ignore events for files that don't exist (#260, #470)

    Previously the inotify watcher would call os.Lstat() to check if a file still exists before emitting events.

    This was inconsistent with other platforms and resulted in inconsistent event reporting (e.g. when a file is quickly removed and re-created), and generally a source of confusion. It was added in 2013 to fix a memory leak that no longer exists.

  • all: return ErrNonExistentWatch when Remove() is called on a path that's not watched (#460)

  • inotify: replace epoll() with non-blocking inotify (#434)

    Non-blocking inotify was not generally available at the time this library was written in 2014, but now it is. As a result, the minimum Linux version is bumped from 2.6.27 to 2.6.32. This hugely simplifies the code and is faster.

  • kqueue: don't check for events every 100ms (#480)

    The watcher would wake up every 100ms, even when there was nothing to do. Now it waits until there is something to do.

  • macos: retry opening files on EINTR (#475)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Issues or PRs related to dependency changes label Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 66.61% // Head: 66.63% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (cc65069) compared to base (d656bd0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
+ Coverage   66.61%   66.63%   +0.01%     
==========================================
  Files         243      243              
  Lines       28090    28090              
==========================================
+ Hits        18713    18718       +5     
+ Misses       8095     8091       -4     
+ Partials     1282     1281       -1     
Flag Coverage Δ
unittests 66.63% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/httputil/reverseproxy.go 85.63% <0.00%> (+0.53%) ⬆️
pkg/scheduler/plugins/coscheduling/core/gang.go 75.39% <0.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Dec 22, 2022

/milestone v1.2

@koordinator-bot koordinator-bot bot added this to the v1.2 milestone Dec 22, 2022
@koordinator-bot koordinator-bot bot removed the lgtm label Jan 10, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 10, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.5.4 to 1.6.0.
- [Release notes](https://github.com/fsnotify/fsnotify/releases)
- [Changelog](https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md)
- [Commits](fsnotify/fsnotify@v1.5.4...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/fsnotify/fsnotify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/fsnotify/fsnotify-1.6.0 branch from f547b32 to cc65069 Compare January 10, 2023 08:32
@hormes
Copy link
Member

hormes commented Jan 10, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 424405b into main Jan 10, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/fsnotify/fsnotify-1.6.0 branch January 10, 2023 10:34
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
…ordinator-sh#849)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Issues or PRs related to dependency changes lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants