Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Fix words typo in error message #851

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

LeoLiuYan
Copy link
Contributor

Signed-off-by: LeoLiuYan 929908264@qq.com

Ⅰ. Describe what this PR does

Fix words typo in error message which returned by utils package.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 67.65% // Head: 67.64% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (fdeae91) compared to base (2a905d1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   67.65%   67.64%   -0.01%     
==========================================
  Files         224      224              
  Lines       25561    25581      +20     
==========================================
+ Hits        17293    17304      +11     
- Misses       7071     7075       +4     
- Partials     1197     1202       +5     
Flag Coverage Δ
unittests 67.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/utils.go 55.73% <100.00%> (+0.73%) ⬆️
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/scheduler/frameworkext/framework_extender.go 59.01% <0.00%> (-1.16%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️
pkg/scheduler/frameworkext/debug_scores.go
pkg/scheduler/frameworkext/debug.go 86.44% <0.00%> (ø)
.../scheduler/plugins/elasticquota/core/quota_info.go 82.47% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: LeoLiuYan <929908264@qq.com>
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 56fe0b1 into koordinator-sh:main Nov 30, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants