Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: make UsageHighEnough configurable for cpu_evict #852

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

fengyehong
Copy link
Contributor

@fengyehong fengyehong commented Dec 1, 2022

Ⅰ. Describe what this PR does

cpu_evict: make UsageHighEnough configurable

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@jasonliu747
Copy link
Member

/cc @zwzhang0107 @saintube

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change, but there might be a better variable naming for CPUEvictBEUsageHighEnough.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 66.45% // Head: 66.50% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (8a66c30) compared to base (4c843e3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   66.45%   66.50%   +0.05%     
==========================================
  Files         233      233              
  Lines       26512    26526      +14     
==========================================
+ Hits        17618    17641      +23     
+ Misses       7665     7653      -12     
- Partials     1229     1232       +3     
Flag Coverage Δ
unittests 66.50% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/cpu_evict.go 74.50% <100.00%> (+0.38%) ⬆️
...heduler/frameworkext/helper/synced_eventhandler.go 75.75% <0.00%> (-7.88%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.26%) ⬆️
pkg/scheduler/plugins/coscheduling/core/gang.go 77.28% <0.00%> (+0.94%) ⬆️
pkg/koordlet/statesinformer/states_pods.go 56.73% <0.00%> (+2.12%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+5.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title cpu_evict: make UsageHighEnough configurable koordlet: make UsageHighEnough configurable for cpu_evict Dec 2, 2022
@zwzhang0107
Copy link
Contributor

this looks good, how about add some UTs for this new config.

@fengyehong
Copy link
Contributor Author

this looks good, how about add some UTs for this new config.

updated

@fengyehong
Copy link
Contributor Author

/retest

@koordinator-bot
Copy link

@fengyehong: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saintube
Copy link
Member

/ok-to-test

Signed-off-by: Guanglu Guo <guoguanglu@qiyi.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube
Copy link
Member

/cc @FillZpp @jasonliu747

@FillZpp
Copy link
Member

FillZpp commented Dec 12, 2022

/approve

@zwzhang0107
Copy link
Contributor

/assign @jasonliu747

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, jasonliu747, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit eb2b14b into koordinator-sh:main Dec 12, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants