Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: ElasticQuota supports Decorator to decorate Node, Pod and ElasticQuota #857

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Dec 5, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

ElasticQuota scheduling plugin supports Decorator interface to decorate Node, Pod and ElasticQuota as needed.
For example, if you want to append some additional resources into Node, Pod and ElasticQuota such as GPU Resources or modify Spec by GPU model, you can implement the Decorator interface.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…d and ElasticQuota

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra
Copy link
Member Author

eahydra commented Dec 5, 2022

@xulinfei1996

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 67.64% // Head: 67.56% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (b83bc0e) compared to base (6b43770).
Patch coverage: 29.31% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   67.64%   67.56%   -0.09%     
==========================================
  Files         224      225       +1     
  Lines       25581    25631      +50     
==========================================
+ Hits        17305    17318      +13     
- Misses       7075     7114      +39     
+ Partials     1201     1199       -2     
Flag Coverage Δ
unittests 67.56% <29.31%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/scheduler/plugins/elasticquota/core/decorator.go 0.00% <0.00%> (ø)
pkg/scheduler/plugins/elasticquota/plugin.go 69.06% <62.50%> (-1.09%) ⬇️
pkg/scheduler/plugins/elasticquota/node_handler.go 67.18% <100.00%> (ø)
pkg/scheduler/plugins/elasticquota/pod_handler.go 67.74% <100.00%> (+3.45%) ⬆️
pkg/scheduler/plugins/elasticquota/preempt.go 40.96% <100.00%> (+0.23%) ⬆️
...kg/scheduler/plugins/elasticquota/quota_handler.go 77.08% <100.00%> (+1.52%) ⬆️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (-0.27%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+1.17%) ⬆️
pkg/koordlet/statesinformer/states_pods.go 56.73% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Dec 5, 2022
@koordinator-bot koordinator-bot bot merged commit c9b77be into koordinator-sh:main Dec 5, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants