-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: ElasticQuota supports Decorator to decorate Node, Pod and ElasticQuota #857
koord-scheduler: ElasticQuota supports Decorator to decorate Node, Pod and ElasticQuota #857
Conversation
…d and ElasticQuota Signed-off-by: Joseph <joseph.t.lee@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportBase: 67.64% // Head: 67.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
- Coverage 67.64% 67.56% -0.09%
==========================================
Files 224 225 +1
Lines 25581 25631 +50
==========================================
+ Hits 17305 17318 +13
- Misses 7075 7114 +39
+ Partials 1201 1199 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/milestone v1.1 |
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
ElasticQuota scheduling plugin supports
Decorator
interface to decorate Node, Pod and ElasticQuota as needed.For example, if you want to append some additional resources into Node, Pod and ElasticQuota such as GPU Resources or modify Spec by GPU model, you can implement the Decorator interface.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test