Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: proposals for collect cpu schedule latency by eBPF #859

Conversation

songtao98
Copy link
Contributor

@songtao98 songtao98 commented Dec 5, 2022

Signed-off-by: songtao98 songtao2603060@gmail.com

Ⅰ. Describe what this PR does

Add proposals that clarifies how to implement cpu schedule latency collector by eBPF.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 67.64% // Head: 66.96% // Decreases project coverage by -0.69% ⚠️

Coverage data is based on head (c4e95c8) compared to base (6b43770).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   67.64%   66.96%   -0.69%     
==========================================
  Files         224      244      +20     
  Lines       25581    28318    +2737     
==========================================
+ Hits        17305    18963    +1658     
- Misses       7075     8054     +979     
- Partials     1201     1301     +100     
Flag Coverage Δ
unittests 66.96% <ø> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/pod.go 7.89% <0.00%> (-30.13%) ⬇️
.../webhook/pod/validating/request_limit_validator.go 71.84% <0.00%> (-23.20%) ⬇️
pkg/koordlet/metriccache/util.go 72.47% <0.00%> (-8.55%) ⬇️
pkg/util/container.go 52.63% <0.00%> (-8.46%) ⬇️
...heduler/frameworkext/helper/synced_eventhandler.go 75.75% <0.00%> (-7.88%) ⬇️
pkg/scheduler/plugins/deviceshare/pod_handler.go 88.05% <0.00%> (-7.13%) ⬇️
pkg/util/cpuset/helper.go 93.33% <0.00%> (-6.67%) ⬇️
pkg/descheduler/controllers/migration/util/util.go 65.07% <0.00%> (-6.62%) ⬇️
pkg/util/pod_resources_utils.go 52.87% <0.00%> (-5.36%) ⬇️
.../scheduler/plugins/nodenumaresource/cpu_manager.go 68.23% <0.00%> (-5.30%) ⬇️
... and 157 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@songtao98 songtao98 force-pushed the proposal_cpu_schedule_latency_and_koordetector branch from 68f09ec to b902963 Compare December 5, 2022 11:04
@songtao98 songtao98 changed the title docs: proposals for collect cpu schedule latency by eBPF and new repo koordetector docs: proposals for collect cpu schedule latency by eBPF Dec 5, 2022
@songtao98 songtao98 force-pushed the proposal_cpu_schedule_latency_and_koordetector branch from b902963 to 8878770 Compare December 8, 2022 08:04
@zwzhang0107
Copy link
Contributor

/milestone v1.2

@koordinator-bot koordinator-bot bot added this to the v1.2 milestone Dec 26, 2022
@songtao98 songtao98 force-pushed the proposal_cpu_schedule_latency_and_koordetector branch from 8878770 to b594c85 Compare January 10, 2023 07:53
@songtao98 songtao98 force-pushed the proposal_cpu_schedule_latency_and_koordetector branch 2 times, most recently from 90271ad to e7ee8f2 Compare January 10, 2023 08:23
Signed-off-by: songtao98 <songtao2603060@gmail.com>
@songtao98 songtao98 force-pushed the proposal_cpu_schedule_latency_and_koordetector branch from e7ee8f2 to c4e95c8 Compare January 31, 2023 08:01
@zwzhang0107
Copy link
Contributor

mv to koordetector

@hormes
Copy link
Member

hormes commented Feb 6, 2023

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

@hormes hormes added the approved label Feb 7, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants