Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: proposal for new repo koordetector #860

Conversation

songtao98
Copy link
Contributor

Signed-off-by: songtao98 songtao2603060@gmail.com

Ⅰ. Describe what this PR does

Add proposals that clarifies the design for new repo koordetector.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 67.55% // Head: 66.49% // Decreases project coverage by -1.06% ⚠️

Coverage data is based on head (d252ab7) compared to base (c9b77be).
Patch has no changes to coverable lines.

❗ Current head d252ab7 differs from pull request most recent head eb5362a. Consider uploading reports for the commit eb5362a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   67.55%   66.49%   -1.07%     
==========================================
  Files         225      233       +8     
  Lines       25631    26757    +1126     
==========================================
+ Hits        17316    17793     +477     
- Misses       7116     7709     +593     
- Partials     1199     1255      +56     
Flag Coverage Δ
unittests 66.49% <ø> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/pod.go 7.89% <0.00%> (-30.13%) ⬇️
pkg/koordlet/metriccache/util.go 72.47% <0.00%> (-8.55%) ⬇️
pkg/util/container.go 52.63% <0.00%> (-8.46%) ⬇️
...heduler/frameworkext/helper/synced_eventhandler.go 75.75% <0.00%> (-7.88%) ⬇️
pkg/util/cpuset/helper.go 93.33% <0.00%> (-6.67%) ⬇️
.../scheduler/plugins/nodenumaresource/cpu_manager.go 68.23% <0.00%> (-5.30%) ⬇️
pkg/koordlet/config/config.go 45.28% <0.00%> (-1.99%) ⬇️
pkg/scheduler/plugins/loadaware/load_aware.go 73.70% <0.00%> (-1.56%) ⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go 75.39% <0.00%> (-0.95%) ⬇️
pkg/koordlet/metriccache/metric_cache.go 59.02% <0.00%> (-0.95%) ⬇️
... and 93 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@songtao98 songtao98 force-pushed the proposal_doc_new_repo_koordetector branch 2 times, most recently from 6be479d to 5d91cd0 Compare December 8, 2022 06:49
@hormes
Copy link
Member

hormes commented Dec 9, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Dec 9, 2022
@songtao98 songtao98 force-pushed the proposal_doc_new_repo_koordetector branch from 5d91cd0 to dbb834b Compare December 18, 2022 07:29
@koordinator-bot koordinator-bot bot removed the lgtm label Dec 18, 2022
@songtao98 songtao98 force-pushed the proposal_doc_new_repo_koordetector branch from d252ab7 to b1d6602 Compare December 18, 2022 07:31
Signed-off-by: songtao98 <songtao2603060@gmail.com>
@songtao98 songtao98 force-pushed the proposal_doc_new_repo_koordetector branch from b1d6602 to eb5362a Compare December 18, 2022 07:34
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Dec 20, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 843c19b into koordinator-sh:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants