-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: fix Coscheduling resource deadlock with groups #873
koord-scheduler: fix Coscheduling resource deadlock with groups #873
Conversation
Thanks for your contribution. Please fix the unit-tests, and add signed off in git commit. |
fd2424f
to
ce7f554
Compare
8d311e7
to
3079b7d
Compare
Codecov ReportBase: 67.52% // Head: 66.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 67.52% 66.85% -0.67%
==========================================
Files 225 234 +9
Lines 25631 26919 +1288
==========================================
+ Hits 17307 17998 +691
- Misses 7121 7644 +523
- Partials 1203 1277 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/milestone v1.2 |
1fdf885
to
13636a9
Compare
13636a9
to
4a3588e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KunWuLuan Hi, thanks for your hard work. Please fix the CI, then we're all set.
4a3588e
to
416b523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
416b523
to
6b70fea
Compare
6b70fea
to
cc44354
Compare
5ec7d98
to
ca54f8c
Compare
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
ca54f8c
to
5596bd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
…dinator-sh#873) Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Ⅰ. Describe what this PR does
fix: deadlock when schedule multi-gang-group
Ⅱ. Does this pull request fix one issue?
fixes #872
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test