Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: NodeCPUBindPolicy supports SpreadByPCPUs #878

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Dec 12, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Currently node.koordinator.sh/cpu-bind-policy only supports FullPCPUsOnly, but in some scenarios users want to configure SpreadByPCPUs for nodes. PR to implement it.

II. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra
Copy link
Member Author

eahydra commented Dec 12, 2022

/hold for UT

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 66.47% // Head: 66.48% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (edcbfa6) compared to base (6e5f565).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   66.47%   66.48%   +0.01%     
==========================================
  Files         233      234       +1     
  Lines       26526    26639     +113     
==========================================
+ Hits        17633    17712      +79     
- Misses       7659     7686      +27     
- Partials     1234     1241       +7     
Flag Coverage Δ
unittests 66.48% <96.96%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/nodenumaresource/plugin.go 66.40% <96.96%> (+3.36%) ⬆️
.../scheduler/plugins/nodenumaresource/cpu_manager.go 68.23% <0.00%> (-5.30%) ⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go 74.44% <0.00%> (-1.90%) ⬇️
pkg/scheduler/plugins/loadaware/load_aware.go 73.70% <0.00%> (-1.56%) ⬇️
pkg/scheduler/plugins/coscheduling/core/core.go 39.72% <0.00%> (-0.42%) ⬇️
pkg/scheduler/plugins/loadaware/helper.go 86.27% <0.00%> (ø)
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra force-pushed the node_cpu_bindpolicy_support_spread branch from e995f9c to 00d2c57 Compare December 12, 2022 16:10
@eahydra
Copy link
Member Author

eahydra commented Dec 12, 2022

/hold cancel

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the node_cpu_bindpolicy_support_spread branch from a42c001 to edcbfa6 Compare December 13, 2022 09:14
@koordinator-bot koordinator-bot bot removed the lgtm label Dec 13, 2022
@eahydra
Copy link
Member Author

eahydra commented Dec 13, 2022

update fine-grained cpu orchestration proposal. cc @FillZpp @ZiMengSheng

@eahydra
Copy link
Member Author

eahydra commented Dec 13, 2022

/milestone v1.1

@koordinator-bot koordinator-bot bot added this to the v1.1 milestone Dec 13, 2022
@ZiMengSheng
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Dec 14, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, hormes, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2d740fd into koordinator-sh:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants